IRC Log for #openid on 2008-02-02
Timestamps are in UTC.
- [00:12:07] * MrTopf (n=cs@pD9EBDFA5.dip.t-dialin.net) Quit ()
- [00:25:31] * shigeta (n=shigeta@70.36.100.220.dy.bbexcite.jp) has joined #openid
- [01:06:36] * flaccid__ (n=flaccid@123-243-80-114.tpgi.com.au) has joined #openid
- [01:22:42] * flaccid_ (n=flaccid@123-243-80-114.tpgi.com.au) Quit (Read error: 110 (Connection timed out))
- [01:32:51] * dazjorz (n=dazjorz@server.dazjorz.com) Quit (No route to host)
- [02:06:12] * flaccid_ (n=flaccid@123-243-80-114.tpgi.com.au) has joined #openid
- [02:20:18] * flaccid__ (n=flaccid@123-243-80-114.tpgi.com.au) Quit (Read error: 110 (Connection timed out))
- [03:24:43] * jrbot (n=supybot@c-71-236-228-127.hsd1.or.comcast.net) Quit (Remote closed the connection)
- [03:33:34] * jrbot (n=supybot@c-71-236-228-127.hsd1.or.comcast.net) has joined #openid
- [03:48:21] * jrbot (n=supybot@c-71-236-228-127.hsd1.or.comcast.net) Quit (Nick collision from services.)
- [03:48:39] * jrbot (n=supybot@c-71-236-228-127.hsd1.or.comcast.net) has joined #openid
- [03:57:57] * flaccid__ (n=flaccid@123-243-80-114.tpgi.com.au) has joined #openid
- [04:08:24] * jrbot (n=supybot@c-71-236-228-127.hsd1.or.comcast.net) Quit (brown.freenode.net irc.freenode.net)
- [04:08:24] * ertai (n=ertai@ns.feydakins.org) Quit (brown.freenode.net irc.freenode.net)
- [04:08:24] * Cody` (n=Cody@74-129-166-74.dhcp.insightbb.com) Quit (brown.freenode.net irc.freenode.net)
- [04:08:24] * miyagawa (n=miyagawa@monster.bulknews.net) Quit (brown.freenode.net irc.freenode.net)
- [04:08:24] * imarcusthis (n=marcus@193.214.115.201) Quit (brown.freenode.net irc.freenode.net)
- [04:08:28] * flaccid__ (n=flaccid@123-243-80-114.tpgi.com.au) Quit (brown.freenode.net irc.freenode.net)
- [04:08:28] * flaccid_ (n=flaccid@123-243-80-114.tpgi.com.au) Quit (brown.freenode.net irc.freenode.net)
- [04:08:28] * SvenDowideit_ (n=SvenDowi@twiki/developer/SvenDowideit) Quit (brown.freenode.net irc.freenode.net)
- [04:08:28] * darix (i=darix@irssi/staff/darix) Quit (brown.freenode.net irc.freenode.net)
- [04:08:28] * michelp_ (n=michelp@69-30-72-119.dq1sf.easystreet.com) Quit (brown.freenode.net irc.freenode.net)
- [04:08:28] * ricky (n=ricky@fedora/ricky) Quit (brown.freenode.net irc.freenode.net)
- [04:08:28] * XRIBot (n=XRIBot@66.36.241.248) Quit (brown.freenode.net irc.freenode.net)
- [04:08:28] * walkah (n=walkah@drupal.org/user/1531/view) Quit (brown.freenode.net irc.freenode.net)
- [04:08:28] * ianloic (i=yakk@glub.dreamhostps.com) Quit (brown.freenode.net irc.freenode.net)
- [04:10:39] * walkah (n=walkah@drupal.org/user/1531/view) has joined #openid
- [04:11:01] * ricky (n=ricky@fedora/ricky) has joined #openid
- [04:11:12] * darix (i=darix@alpha049.server4you.de) has joined #openid
- [04:18:27] * jrbot (n=supybot@c-71-236-228-127.hsd1.or.comcast.net) has joined #openid
- [04:18:27] * ertai (n=ertai@ns.feydakins.org) has joined #openid
- [04:18:27] * Cody` (n=Cody@74-129-166-74.dhcp.insightbb.com) has joined #openid
- [04:18:27] * imarcusthis (n=marcus@193.214.115.201) has joined #openid
- [04:18:27] * miyagawa (n=miyagawa@monster.bulknews.net) has joined #openid
- [04:18:27] <jibot>
miyagawa is Tatsuhiko Miyagawa, the author of Plagger <http://plagger.org> and works on Vox <http://www.vox.com> in Six Apart.
- [04:22:33] * michelp_ (n=michelp@69-30-72-119.dq1sf.easystreet.com) has joined #openid
- [04:23:35] * SvenDowideit_ (n=SvenDowi@twiki/developer/SvenDowideit) has joined #openid
- [04:39:01] * Rpg2 (n=Ramha@p508458A0.dip.t-dialin.net) has joined #openid
- [04:46:27] * _keturn (n=acapnoti@pdpc/supporter/sustaining/keturn) Quit (Read error: 110 (Connection timed out))
- [04:48:06] * ricky_ (n=ricky@fedora/ricky) has joined #openid
- [04:48:14] * jrbot (n=supybot@c-71-236-228-127.hsd1.or.comcast.net) Quit (Read error: 110 (Connection timed out))
- [04:50:05] * rorek (n=rorek@c-71-236-228-127.hsd1.or.comcast.net) Quit (Read error: 110 (Connection timed out))
- [04:59:57] * rorek (n=rorek@c-71-236-228-127.hsd1.or.comcast.net) has joined #openid
- [05:00:23] * _keturn (n=acapnoti@pdpc/supporter/sustaining/keturn) has joined #openid
- [05:00:45] * ricky (n=ricky@fedora/ricky) Quit (Read error: 113 (No route to host))
- [05:00:55] * jrbot (n=supybot@c-71-236-228-127.hsd1.or.comcast.net) has joined #openid
- [05:00:56] * ricky_ is now known as ricky
- [05:42:46] * a9913 (n=a9913@unaffiliated/a9913) has joined #openid
- [05:52:51] * Rpg2 (n=Ramha@p508458A0.dip.t-dialin.net) has left #openid
- [06:20:51] * flaccid (n=flaccid@123-243-80-114.tpgi.com.au) has joined #openid
- [06:29:27] * flaccid_ (n=flaccid@123-243-80-114.tpgi.com.au) has joined #openid
- [06:41:10] * flaccid (n=flaccid@123-243-80-114.tpgi.com.au) Quit (Connection timed out)
- [06:49:50] * flaccid__ (n=flaccid@123-243-80-114.tpgi.com.au) has joined #openid
- [06:50:41] * a9913 (n=a9913@unaffiliated/a9913) Quit ("Leaving")
- [06:57:39] * flaccid_ (n=flaccid@123-243-80-114.tpgi.com.au) Quit (Read error: 110 (Connection timed out))
- [06:58:30] * illustir (n=alper@s55912056.adsl.wanadoo.nl) has joined #openid
- [07:00:14] * flaccid_ (n=flaccid@123-243-80-114.tpgi.com.au) has joined #openid
- [07:11:30] * shigeta (n=shigeta@70.36.100.220.dy.bbexcite.jp) Quit ("Leaving...")
- [07:17:19] * flaccid__ (n=flaccid@123-243-80-114.tpgi.com.au) Quit (Read error: 110 (Connection timed out))
- [07:21:11] * polyonymous (n=hacker@pD953B1A7.dip0.t-ipconnect.de) Quit (Read error: 110 (Connection timed out))
- [07:23:26] * flaccid_ (n=flaccid@123-243-80-114.tpgi.com.au) Quit (Read error: 110 (Connection timed out))
- [07:23:51] * polyonymous (n=hacker@pD953B069.dip0.t-ipconnect.de) has joined #openid
- [07:25:38] * illustir (n=alper@s55912056.adsl.wanadoo.nl) Quit ()
- [08:07:26] * tjohns (n=tjohns@cpe-76-170-58-80.socal.res.rr.com) has joined #openid
- [08:18:03] * shigeta (n=shigeta@70.36.100.220.dy.bbexcite.jp) has joined #openid
- [08:24:29] * priidu (n=aa@221.220.72.205) has joined #openid
- [08:27:48] * priidu (n=aa@221.220.72.205) Quit (Client Quit)
- [09:02:18] * shigeta (n=shigeta@70.36.100.220.dy.bbexcite.jp) Quit ("Leaving...")
- [09:14:59] * a9913 (n=a9913@unaffiliated/a9913) has joined #openid
- [09:15:21] * mario (n=chatzill@89.241.154.67) has joined #openid
- [09:15:25] * flaccid (n=flaccid@123-243-80-114.tpgi.com.au) has joined #openid
- [09:40:33] * pvandewyngaerde (n=pvandewy@235.81-64-87.adsl-dyn.isp.belgacom.be) has joined #openid
- [09:50:06] * NASA (n=nasa@78-62-27-29.ip.zebra.lt) has joined #openid
- [09:54:58] * mario (n=chatzill@89.241.154.67) Quit (Read error: 113 (No route to host))
- [10:24:12] * dazjorz (n=dazjorz@server.dazjorz.com) has joined #openid
- [10:24:29] * dazjorz (n=dazjorz@server.dazjorz.com) Quit (Client Quit)
- [10:24:31] * dazjorz (n=dazjorz@server.dazjorz.com) has joined #openid
- [10:28:03] * a9913 (n=a9913@unaffiliated/a9913) Quit (Read error: 113 (No route to host))
- [10:49:48] * idnar (i=mithrand@unaffiliated/idnar) Quit (Read error: 110 (Connection timed out))
- [10:51:29] * idnar (n=mithrand@unaffiliated/idnar) has joined #openid
- [10:55:23] * pvandewyngaerde (n=pvandewy@235.81-64-87.adsl-dyn.isp.belgacom.be) Quit (Remote closed the connection)
- [11:07:19] * flaccid_ (n=flaccid@123-243-80-114.tpgi.com.au) has joined #openid
- [11:18:03] * flaccid (n=flaccid@123-243-80-114.tpgi.com.au) Quit (Read error: 110 (Connection timed out))
- [11:24:08] * NASA (n=nasa@78-62-27-29.ip.zebra.lt) Quit ("Ate")
- [11:37:57] * flaccid__ (n=flaccid@123-243-80-114.tpgi.com.au) has joined #openid
- [11:39:56] * shigeta (n=shigeta@70.36.100.220.dy.bbexcite.jp) has joined #openid
- [11:43:46] * flaccid__ (n=flaccid@123-243-80-114.tpgi.com.au) Quit ("Konversation terminated!")
- [11:51:44] * flaccid_ (n=flaccid@123-243-80-114.tpgi.com.au) Quit (Read error: 110 (Connection timed out))
- [12:22:51] * flaccid (n=flaccid@123-243-80-114.tpgi.com.au) has joined #openid
- [12:42:44] * tjohns (n=tjohns@cpe-76-170-58-80.socal.res.rr.com) Quit ()
- [12:54:32] * flaccid_ (n=flaccid@123-243-80-114.tpgi.com.au) has joined #openid
- [13:08:58] * flaccid (n=flaccid@123-243-80-114.tpgi.com.au) Quit (Read error: 110 (Connection timed out))
- [13:33:42] * a9913 (n=a9913@unaffiliated/a9913) has joined #openid
- [14:04:30] * flaccid_ (n=flaccid@123-243-80-114.tpgi.com.au) Quit (Read error: 110 (Connection timed out))
- [14:07:21] * MrTopf (n=cs@pD9EBE2A1.dip.t-dialin.net) has joined #openid
- [14:28:51] * lstryder (n=lstryder@87.112.93.18.plusnet.ptn-ag2.dyn.plus.net) has joined #openid
- [14:38:11] * lstryder (n=lstryder@87.112.93.18.plusnet.ptn-ag2.dyn.plus.net) has left #openid
- [14:48:57] * dazjorz (n=dazjorz@server.dazjorz.com) Quit (Connection timed out)
- [14:50:31] * Makenshi (n=makenshi@makenshi.at.furry.be) Quit (Read error: 110 (Connection timed out))
- [14:53:19] * a9913 (n=a9913@unaffiliated/a9913) Quit ("Leaving")
- [14:53:34] * a9913 (n=a9913@unaffiliated/a9913) has joined #openid
- [15:03:43] * Mitsu is now known as Mitsurugi
- [15:15:00] * a9913 (n=a9913@unaffiliated/a9913) Quit ("Leaving")
- [15:25:36] * Cody` (n=Cody@74-129-166-74.dhcp.insightbb.com) Quit (Read error: 104 (Connection reset by peer))
- [15:50:36] * mario_ (n=chatzill@89.241.154.67) has joined #openid
- [15:53:36] * l0gic (n=l0gic@84.91.8.144) Quit (Nick collision from services.)
- [15:54:16] * l0gic (n=l0gic@84.91.8.144) has joined #openid
- [15:54:31] * flaccid (n=flaccid@123-243-80-114.tpgi.com.au) has joined #openid
- [16:03:34] * a9913 (n=a9913@unaffiliated/a9913) has joined #openid
- [16:06:44] * arty_name (n=atregoub@217-117-114-135.proc.ru) has joined #openid
- [16:07:51] <arty_name>
Hello. I'm developing memcached store for php-openid library, an I have a question on contradiction between tests and docs.
- [16:08:15] * a9913 (n=a9913@unaffiliated/a9913) Quit (Client Quit)
- [16:08:36] <arty_name>
PHPdoc comment says about removeAssociation(): 'Returns whether or not the given association existed'
- [16:09:26] <arty_name>
however test says: Failure in test_memcachedstore: Remove nonexistent association (1) expected TRUE, actual FALSE
- [16:11:18] <arty_name>
the question is: should I believe comments in Auth_OpenID_OpenIDStore or believe tests?
- [16:14:00] * flaccid_ (n=flaccid@123-243-80-114.tpgi.com.au) has joined #openid
- [16:29:49] * flaccid (n=flaccid@123-243-80-114.tpgi.com.au) Quit (Read error: 110 (Connection timed out))
- [16:38:07] * _keturn (n=acapnoti@pdpc/supporter/sustaining/keturn) Quit (Read error: 110 (Connection timed out))
- [16:39:44] * jrbot (n=supybot@c-71-236-228-127.hsd1.or.comcast.net) Quit (Read error: 110 (Connection timed out))
- [16:41:52] * rorek (n=rorek@c-71-236-228-127.hsd1.or.comcast.net) Quit (Read error: 110 (Connection timed out))
- [16:42:39] * Mitsurugi (n=Nightmar@160.Red-81-38-21.dynamicIP.rima-tde.net) Quit (Read error: 110 (Connection timed out))
- [16:43:57] * Mitsurugi (n=Nightmar@79.Red-81-44-39.dynamicIP.rima-tde.net) has joined #openID
- [16:51:47] * idnar (n=mithrand@unaffiliated/idnar) Quit (Read error: 110 (Connection timed out))
- [17:16:58] <donomo>
arty_name: could the comments be right and the test is broken?
- [17:18:14] <arty_name>
Actually both were right, it's just difficult to correctly interpret this line: "Failure in test_memcachedstore: Remove nonexistent association (1) expected TRUE, actual FALSE"
- [17:19:33] <arty_name>
i've completed my store now, it passes required tests, now it's time to add some comments
- [17:38:44] * idnar (i=mithrand@unaffiliated/idnar) has joined #openid
- [17:39:26] * mario_ (n=chatzill@89.241.154.67) Quit (Read error: 113 (No route to host))
- [17:44:16] <PibbRelay>
<cygnus> Yeah, I was going to say.. the "expected" and "actual" values are probably flipped in the assertion.
- [17:44:48] <PibbRelay>
<cygnus> mostly that's due to the difference between Python's unittest and PHPUnit's assertion call styles. when we port the code, we don't flip the assertions. :(
- [17:48:01] * a9913 (n=a9913@unaffiliated/a9913) has joined #openid
- [17:48:20] <arty_name>
btw, why darcs shows '$' signs in diff while recording?
- [17:50:17] <donomo>
$ marks the end of a line
- [17:50:26] <donomo>
i think darcs uses it to show a line has trailing whitespace
- [17:51:17] <arty_name>
I see, thanks!
- [17:57:15] <flaccid_>
heya cygnus
- [18:02:24] <arty_name>
one more question about tests: i've got php-postgres module, but I want to skip testing of postgres store, can I do that without patches?
- [18:03:26] <arty_name>
I mean without changing code, which goes to patch
- [18:10:38] * rorek (n=rorek@c-71-236-228-127.hsd1.or.comcast.net) has joined #openid
- [18:11:06] * _keturn (n=acapnoti@pdpc/supporter/sustaining/keturn) has joined #openid
- [18:12:35] * jrbot (n=supybot@c-71-236-228-127.hsd1.or.comcast.net) has joined #openid
- [18:16:50] * lstryder (n=lstryder@87.112.93.18.plusnet.ptn-ag2.dyn.plus.net) has joined #openid
- [18:21:21] <arty_name>
argh! Making new store wasn't as diffucult as avoiding this irrelevant postgres test is !
- [18:21:53] * cygnus (n=jonathan@c-24-22-45-171.hsd1.or.comcast.net) has joined #openid
- [18:21:53] <jibot>
cygnus is WorkerBee(name="Jonathan Daugherty", company="JanRain, Inc.")
- [18:22:17] <cygnus>
arty_name: Hmm, that sucks. :( The tests really should pass if they can't connect to the database, since that's not really a failure condition.
- [18:22:45] <arty_name>
should I write a patch for this?
- [18:23:02] <arty_name>
i've already found one typo there, it also was a blocker
- [18:23:26] <cygnus>
arty_name: what you can do is 1) edit the test files to disable the tests you don't want to run, 2) run the tests manually to make sure your new tests pass, then 3) record your patch, only recording hunks that you added, and NOT the ones to disable the store tests, and pass "--no-test" to "darcs record" to have it not run the tests.
- [18:24:14] <arty_name>
thanks! i didn't knew about this --no-test flag
- [18:24:16] <cygnus>
actually, if you first patch the code to pass when it can't connect to the mysql and postgres databases, that would be great.
- [18:24:35] <cygnus>
so in the code that currently calls $this->fail(...) upon connection failure, call $this->pass() instead.
- [18:24:42] <cygnus>
record that patch first, then record yours.
- [18:24:42] <arty_name>
ok, i will, but for pg only, as I don't have mysql here
- [18:28:10] <arty_name>
cygnus, is it absolutely a must to have cleanup*() function in store implementation? Docs say these are needed only for admins, and memcache cleans itsself.
- [18:29:33] <cygnus>
You should implement it, but have it do nothing. the interface may be expected by other code that doesn't want to care what sort of store object it is using.
- [18:29:58] <cygnus>
although the base class may; let me check.
- [18:31:09] <cygnus>
Ahh, ok, implementing cleanup() for your store is probably best. In reality, cleanup() is a shortcut for cleanupNonces() and cleanupAssociations(), which will trigger errors if they're not overridden.
- [18:31:20] <cygnus>
to be safe, you should implement all three, and have them all do nothing.
- [18:32:37] <arty_name>
ok, I did, and patched tests (optionally) not to depend on cleanups to success - is it ok too?
- [18:34:20] * flaccid_ bangs away at cakephp OP controller
- [18:35:27] <cygnus>
arty_name: while memcached can clean itself up, I don't really see any reason to break the idiom and have the memcached store not implement cleanup. that's the expected behavior for all of the stores, and it shouldn't be too hard to implement, right?
- [18:35:44] <cygnus>
arty_name: I'm having a hard time thinking of a good reason to omit it.
- [18:36:58] <arty_name>
cygnus, memcached doesn't allow to list all stored keys
- [18:37:51] <cygnus>
Oh. :-/
- [18:37:58] <arty_name>
thus the only way to clean it up would be to store global list of all used associations in it
- [18:39:09] <arty_name>
and I don't think its a good idea to send this amount of data over network every time we need to add a nonce or association
- [18:39:17] <cygnus>
agreed
- [18:39:25] <cygnus>
so you can do a couple of things:
- [18:40:20] <cygnus>
you can either 1) add a method to Auth_OpenID_Interface, supportsCleanup(), which returns true in the base class, and override it in the memcached store and have it return false and update the tests to only run it accordingly, or 2) you can get everything else working in your patch except cleanup() and record it with --no-tests and send it to the dev list (or me directly) and we'll take care of that bit internally.
- [18:42:22] <arty_name>
well, first option seems even better then my first idea
- [18:43:13] <arty_name>
i'll do it
- [18:44:30] <keturn>
we used to have a memcached store in the python code, long ago. before cleanup(). but there was some other reason it didn't work too well. I don't remember what it was, but j3h probably does.
- [18:50:12] * dazjorz_ (n=dazjorz@server.dazjorz.com) has joined #openid
- [18:51:12] * shigeta (n=shigeta@70.36.100.220.dy.bbexcite.jp) Quit ("Leaving...")
- [18:53:03] * dazjorz_ is now known as dazjorz
- [19:10:48] * MrTopf (n=cs@pD9EBE2A1.dip.t-dialin.net) Quit ()
- [19:24:51] * lstryder (n=lstryder@87.112.93.18.plusnet.ptn-ag2.dyn.plus.net) Quit (Client Quit)
- [19:38:27] * cygnus (n=jonathan@c-24-22-45-171.hsd1.or.comcast.net) has left #openid
- [19:50:41] * arty_name (n=atregoub@217-117-114-135.proc.ru) has left #openid
- [20:15:18] * flaccid__ (n=flaccid@123-243-80-114.tpgi.com.au) has joined #openid
- [20:30:22] * nicknic (n=njones@c-67-169-24-22.hsd1.ca.comcast.net) has joined #openid
- [20:31:31] * flaccid_ (n=flaccid@123-243-80-114.tpgi.com.au) Quit (Connection timed out)
- [20:36:37] * a9913 (n=a9913@unaffiliated/a9913) Quit ("Leaving")
- [20:43:06] * flaccid_ (n=flaccid@123-243-80-114.tpgi.com.au) has joined #openid
- [20:43:37] * KjetilK (n=kjetil@cm-84.208.172.230.getinternet.no) has joined #openid
- [20:44:33] <KjetilK>
It seems I have a problem logging into wordpress sites, anyone here involved in developing the wp plugin?
- [20:45:18] <KjetilK>
the thing is that I use content negotation on my URL, so apparently the client gets a 406
- [20:45:46] <KjetilK>
I would guess it lacks a Accept-Languages: *
- [20:45:52] * mario_ (n=chatzill@89.241.154.67) has joined #openid
- [20:45:54] * mario_ is now known as mario
- [21:00:04] * flaccid__ (n=flaccid@123-243-80-114.tpgi.com.au) Quit (Connection timed out)
- [21:05:29] * mario (n=chatzill@89.241.154.67) Quit (Read error: 113 (No route to host))
- [21:08:02] * MrTopf (n=cs@pD9EBE2A1.dip.t-dialin.net) has joined #openid
- [21:35:19] * nicknic (n=njones@c-67-169-24-22.hsd1.ca.comcast.net) Quit ()
- [21:42:12] * flaccid__ (n=flaccid@123-243-80-114.tpgi.com.au) has joined #openid
- [21:45:11] * mario_ (n=chatzill@89.241.154.67) has joined #openid
- [21:45:12] * mario_ is now known as mario
- [21:58:38] * flaccid_ (n=flaccid@123-243-80-114.tpgi.com.au) Quit (Connection timed out)
- [22:24:03] * flaccid_ (n=flaccid@123-243-80-114.tpgi.com.au) has joined #openid
- [22:40:54] * flaccid__ (n=flaccid@123-243-80-114.tpgi.com.au) Quit (Connection timed out)
- [22:56:33] * MrTopf (n=cs@pD9EBE2A1.dip.t-dialin.net) Quit ()
- [23:14:24] * tjohns (n=tjohns@cpe-76-170-58-80.socal.res.rr.com) has joined #openid
- [23:47:00] * Mitsurugi (n=Nightmar@79.Red-81-44-39.dynamicIP.rima-tde.net) Quit (Read error: 104 (Connection reset by peer))
- [23:50:38] * rebel_leader (n=Horst@X4fd2.x.pppool.de) has joined #openid
- [23:52:37] * rebel_leader (n=Horst@X4fd2.x.pppool.de) Quit (Client Quit)
These logs were automatically created by OpenIDlogbot on
chat.freenode.net
using a modified version of the Java IRC LogBot.